ThinBridge / Chronos

Chromiumベースの業務ブラウザ
Other
5 stars 3 forks source link

Use more meaningful label for output logging configuration #125

Closed kenhys closed 11 months ago

kenhys commented 11 months ago

Which issue(s) this PR fixes:

CSG#14

What this PR does / why we need it:

Even though this option is disabled, it is still enabled for loggging with TRACE Log Monitor Window. Thus this option actually controls whether output to Chronos trace.log or not.

It should represent actual behaviour precisely.

How to verify the fixed issue:

  1. Launch ChronosN.exe
  2. Click Tools > Preferences menu
  3. Check Logging category and DebugLog preference

Expected result:

kenhys commented 11 months ago

enable-logging-option-en

chronos-pr-125-ja

yashirot commented 11 months ago

The improved text in Japanese is looking good to me.

As for text in English, however,

kenhys commented 11 months ago

rebased with master.

HashidaTKS commented 11 months ago

LGTM.

HashidaTKS commented 11 months ago

Memo:

Text within 'DebugLog' box is apparently not fully shown to the right end--This should be another issue anyway.

This is also fixed at this PR.