ThinBridge / Chronos

Chromiumベースの業務ブラウザ
Other
5 stars 3 forks source link

Support EnableMediaAccessPermission configuration #134

Closed kenhys closed 11 months ago

kenhys commented 11 months ago

Which issue(s) this PR fixes:

98

What this PR does / why we need it:

In the previous versions, there is no way to configure enable permission by default without manual approval.

This commit introduce EnableMediaAccessPermission, which means:

0: no permission (block media access) 1: manual approval 2: approval by default without manual permission

This is replacement of EnableMediaAccessByApproval. EnableMeiaAccessByApproval configuration setting is deprecated and not used anymore.

How to verify the fixed issue:

Native edition with no access to media

  1. Ensure no EnableMediaAccessPermission entry in ChronosDefault.conf
  2. Lauch Chronos
  3. Access https://meet.jit.si/
  4. Start meeting
  5. No request to access media
  6. Quit Chronos
  7. Ensure EnableMediaAccessPermission=0 entry in ChronosDefault.conf
  8. Launch Chronos
  9. Access https://meet.jit.si/
  10. Start meeting
  11. No request to access media

Native edition with manual approval

  1. Ensure no EnableMediaAccessPermission=1 entry in ChronosDefault.conf
  2. Lauch Chronos
  3. Access https://meet.jit.si/
  4. Start meeting
  5. Ensure requested access to media confirmation dialog.

Native edition with default approval

  1. Ensure no EnableMediaAccessPermission=2 entry in ChronosDefault.conf
  2. Lauch Chronos
  3. Access https://meet.jit.si/
  4. Start meeting
  5. Ensure no request to access media

Native edition with manual approval (migration)

  1. Ensure no EnableMediaAccessByApproval=1 entry in ChronosDefault.conf (No EnableMediaAccesByApproval entry)
  2. Lauch Chronos
  3. Access https://meet.jit.si/
  4. Start meeting
  5. Ensure requested access to media confirmation dialog.
  6. Quit
  7. Ensure EnableMediaAccessByApproval entry

Expected result:

Native edition with no access to media

Native edition with manual approval to media

Native edition with default approval

Native edition with manual approval (migration)

kenhys commented 11 months ago

Updated explanation & expected behavior.