search

ThinBridge / Chronos

Chromiumベースの業務ブラウザ
Other
5 stars 3 forks source link

Revise assigned ID for consistency #137

Closed kenhys closed 8 months ago

kenhys commented 8 months ago

Which issue(s) this PR fixes:

N/A

This PR is folllwup of #135 feedback.

What this PR does / why we need it:

In the previous versions, there are many case that same id is assigned to multiple targets.

This situation is not unwanted and potencial inconsistency should be fixed.

  #define IDD_DLG_PROGRESS                142
  #define IDS_PROPRIETARY_CODEC_LICENSES  142 (Unused)
  #define IDS_STRING_PROPRIETARY_CODEC_LICENSES 142

  #define IDS_CERTIFICATION_VALID_PERIOD  438 (Unused)
  #define ID_CERTIFICATION_VALID_PERIOD   438

  #define IDC_VOS_CLOSE_PROCESS           1346
  #define IDC_EnableUploadRestriction     1346
  #define IDC_SHOW_DEV_TOOLS              1347
  #define IDC_EnableDownloadRestriction   1347
  #define IDC_EDIT_CustomBrowser1         1348
  #define IDC_EnableDeleteCache           1348
  #define IDC_CEF_VERSION                 1348

How to verify the fixed issue:

This is internal change.