Closed HashidaTKS closed 3 months ago
https://github.com/ThinBridge/Chronos/issues/42
The fallthrough at this line is intended, no need to warn. So having added a [[fallthrough]]; statement to avoid warning C26819.
[[fallthrough]];
https://learn.microsoft.com/en-us/cpp/code-quality/c26819?view=msvc-170
Describe the following information to help that the tester able to do it.
The warning is suppressed
Regression test
The warning C26819 is suppressed, the warning is not displayed.
The tab moves fine.
:eyes:
kenhys
commented
3 months ago kenhys
commented
3 months ago
Which issue(s) this PR fixes:
https://github.com/ThinBridge/Chronos/issues/42
What this PR does / why we need it:
The fallthrough at this line is intended, no need to warn. So having added a
[[fallthrough]];statement to avoid warning C26819.https://learn.microsoft.com/en-us/cpp/code-quality/c26819?view=msvc-170
How to verify the fixed issue:
The steps to verify:
The warning is suppressed
Regression test
Expected result:
The warning is suppressed
The warning C26819 is suppressed, the warning is not displayed.
Regression test
The tab moves fine.