Show logo on the Rebar works only when Show Rebar is enabled.
So we should indent the Show logo on the Rebar checkbox, and enable it only when the Show Rebar checkbox is checked.
When the Show Rebar checkbox is checked:
When the Show Rebar checkbox is unchecked:
How to verify the fixed issue:
The steps to verify:
Open appearance setting dialog.
Click the Show Rebar checkbox multiple times.
Close and re-open appearance setting dialog with the enabled "Show Rebar" checkbox.
Close and re-open appearance setting dialog with the disabled "Show Rebar" checkbox.
Expected result:
The Show logo on the Rebar checkbox is indented.
The Show logo on the Rebar checkbox is enabled if the "Show Rebar" checkbox is checked, disabled if unchecked.
The Show logo on the Rebar checkbox is enabled when re-opening.
The Show logo on the Rebar checkbox is disabled when re-opening.
kenhys
commented
3 months ago
Which issue(s) this PR fixes:
https://github.com/ThinBridge/Chronos-SG/issues/11
What this PR does / why we need it:
Show logo on the Rebarworks only whenShow Rebaris enabled. So we should indent theShow logo on the Rebarcheckbox, and enable it only when theShow Rebarcheckbox is checked.When the
Show Rebarcheckbox is checked:When the
Show Rebarcheckbox is unchecked:How to verify the fixed issue:
The steps to verify:
Show Rebarcheckbox multiple times.Expected result:
Show logo on the Rebarcheckbox is indented.Show logo on the Rebarcheckbox is enabled if the "Show Rebar" checkbox is checked, disabled if unchecked.Show logo on the Rebarcheckbox is enabled when re-opening.Show logo on the Rebarcheckbox is disabled when re-opening.