ThinBridge / Chronos

Chromiumベースの業務ブラウザ
Other
5 stars 3 forks source link

Disable first party sets #195

Closed HashidaTKS closed 1 month ago

HashidaTKS commented 1 month ago

Which issue(s) this PR fixes:

https://github.com/ThinBridge/Chronos-SG/issues/248

What this PR does / why we need it:

CEF119 has a bug that CEF crashes when a mouse cursor enters to a search box of YouTube when first party sets is enabled.

https://github.com/chromiumembedded/cef/issues/3643

We disable first party sets as temporary measure.

The bug is fixed since CEF122, so we can enable first party sets if we adopt to use CEF122+.

By following https://privacysandbox.com/open-web/#the-privacy-sandbox-timeline/ and https://cloud.google.com/looker/docs/best-practices/chrome-third-party-cookie-deprecation?hl=en, third party cookies are unsupported since 1/2024 and CEF119 is released on 2023, so CEF119 supports third party cookies. As a result, it seems that we can simply disable first party sets on CEF119.

How to verify the fixed issue:

The steps to verify:

Confirm bug fixe

Regression test

kenhys commented 1 month ago

confirmed that crash will not occur and can login to google accounts.

kenhys commented 1 month ago

Occasionally, login process to google account is blocked but it may depend on a situation. (false detection with RPA access?)