ThinBridge / Chronos

Chromiumベースの業務ブラウザ
Other
5 stars 3 forks source link

Remove EnableDeleteCache #200

Closed HashidaTKS closed 2 weeks ago

HashidaTKS commented 3 weeks ago

Which issue(s) this PR fixes:

N/A

Related: #199

What this PR does / why we need it:

In SG mode (ThinApp mode), a data folder is always removed on shutting down, so EnableDeleteCache = false doesn't work as expected, which is a specification (limitation) of ThinApp. Also, since CEF120, we should specify unique cache folder for each instances, that make re-using cache folder difficult.

Because of the reason above, we should remove EnableDeleteCache.

How to verify the fixed issue:

The steps to verify:

kenhys commented 2 weeks ago

@HashidaTKS could you resolve conflict because #199 was merged into master.

HashidaTKS commented 2 weeks ago

@HashidaTKS could you resolve conflict because #199 was merged into master.

Sure, I have resolved the conflict.