search

ThingEngineer / PHP-MySQLi-Database-Class

Wrapper for a PHP MySQL class, which utilizes MySQLi and prepared statements.
Other
3.3k stars 1.34k forks source link

wrong implode function parameters #1019

Closed nathanaelmemis closed 4 months ago

nathanaelmemis commented 1 year ago

MysqliDb.php, line 1838: $this->_query .= ' (' . implode($dataColumns, ', ') . ') ';

should be

$this->_query .= ' (' . implode(', ', $dataColumns) . ') ';

note: this is for the last release

decMuc commented 10 months ago

I find this surprising. I have an insert statement in two different classes – it works in one class, but in the other, I encounter an error in the exact same line. When I swap the line between the classes, it now works in the previously problematic class. I just can't comprehend why it works in one class while being nearly identical to the other.

ThingEngineer commented 4 months ago

I missed this issue when I merged a fix from a duplicate issue. Fixed in Merge pull request #1028