search

ThingEngineer / PHP-MySQLi-Database-Class

Wrapper for a PHP MySQL class, which utilizes MySQLi and prepared statements.
Other
3.3k stars 1.34k forks source link

Fix potential null issue in rawAddPrefix method #1021

Closed CassianoRafael closed 6 months ago

CassianoRafael commented 1 year ago

This PR addresses a potential issue in the rawAddPrefix method where, if the provided SQL query does not contain keywords like "from", "into", "update", "join", or "describe" (e.g. functions and procedures), the $table array would be empty, leading to a PHP deprecated warning in the newer versions.

The proposed solution adds a conditional check to ensure that there are table name matches before proceeding with the replacement.

CassianoRafael commented 1 year ago

@avbdr when you have time, can you please review it?

ThingEngineer commented 6 months ago

Thanks for the pull request, @CassianoRafael! This looks like a valuable fix for a potential null issue in the rawAddPrefix method. I appreciate you catching this and taking the time to contribute (especially as a first-time contributor!).

The issue @CassianoRafael identified is likely valid. Here's why:

PHP Deprecated Warnings: In newer PHP versions, accessing properties of potentially null variables can trigger warnings. The proposed fix with a conditional check avoids this scenario. Unexpected Behavior: If the $table array remains empty due to missing keywords like "from," unexpected behavior could occur when the prefix is added. This fix helps prevent such issues.