mostly cosmetic and very small changes

ThingEngineer / PHP-MySQLi-Database-Class

Wrapper for a PHP MySQL class, which utilizes MySQLi and prepared statements.

Other

3.29k stars 1.35k forks source link

mostly cosmetic and very small changes #982

Open EnthusiastNT opened 2 years ago

EnthusiastNT commented 2 years ago

- added a check on isset($table[0]) because that threw an error once
- utf8mb4 instead of utf8 as default as recommended in the docs
- mb_substr instead of substr since we use utf8
- added 3 function aliases for easier understanding (see CHANGED)
- corrected some spelling and grammar in comments
- removed a few "@throws Exception" where it wasn't throwing anything
- added some line breaks for consistency
- moved orWhere() after where() because... OCD I guess

avbdr commented 1 year ago

@EnthusiastNT great cleanup thank you. Can you please remove all the noise comments like CHANGED, remove a changelog on top and as well remove new introdouced helper functions? I dont see much use of this functions since they are acting as 'sugar for the sugar'. I will be happy to merge this in after. Thank you again