search

ThingEngineer / PHP-MySQLi-Database-Class

Wrapper for a PHP MySQL class, which utilizes MySQLi and prepared statements.
Other
3.3k stars 1.34k forks source link

Is this project still alive? #995

Closed iahim closed 6 months ago

iahim commented 2 years ago

I don't see too much movement in the last 2 years...

peterlaws commented 2 years ago

I still use it religiously.

mihaiflorio commented 2 years ago

I still use it religiously.

I have tried to use it lately but i have a warning ... using php 7.4.30. PHP Notice: Undefined offset: 0 in vendor/thingengineer/mysqli-database-class/MysqliDb.php on line 559

peterlaws commented 2 years ago

That is just a notice - but it works despite that??...... I use it with 8.0, no issues...

But, I agree, would like some input from the author, @ThingEngineer

mihaiflorio commented 2 years ago

That is just a notice - but it works despite that??...... I use it with 8.0, no issues...

But, I agree, would like some input from the author, @ThingEngineer

Yeah it does work, is just annoying :)

avbdr commented 2 years ago

Sorry guys, I'll work this notice next week. Apart from that everything is working fine in the library?

I'll release next version with this fix.

On Sun, Sep 11, 2022, 2:34 PM mihaiflorio @.***> wrote:

I still use it religiously.

I have tried to use it lately but i have a warning ... using php 7.4.30. PHP Notice: Undefined offset: 0 in vendor/thingengineer/mysqli-database-class/MysqliDb.php on line 559

— Reply to this email directly, view it on GitHub https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/issues/995#issuecomment-1243018901, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZCL4XADZVMYQKNAA7SYQDV5YQ5BANCNFSM572YMTFA . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

mihaiflorio commented 2 years ago

@avbdr on php 7.4.30 seems to work just fine (apart of the notice). Thanks a lot for fixing it.

funder7 commented 1 year ago

Hi guys, I'm using this package since 2016 and it worked always very well. In the next months I'll need to migrate a project to php 8.x, and I would like to keep using this library if possible. It's not 100% clear if it's compatible with php 8, as there are some open issues about it, while some people says that it's working. I can give some support if needed...

Just let me know, in case. Bye!

iahim commented 1 year ago

@funder7 it does work, i use it with php8. there is indeed that weird notice (but it does not break the code). I was thinking about forking it ... if the owner does not update it anymore.

avbdr commented 1 year ago

I dont know what else to add to the library, I think it is good as is and further "improvements" less likely will bring anything major anymore. I have to sit to fix php8 related deprecation notices with a backwards compatibility, this is so far the only thing in my todo

iahim commented 1 year ago

@avbdr totally agree, there is no need for further improvements, just the fix for php8. I do not think is too much work, I can pay you to fix it (my OCD always is getting crazy when I see the NOTICE from the library) :)))))) I am serious about it - let me know how much it costs, to have it fixed sooner than later.

peterlaws commented 1 year ago

(my OCD always is getting crazy when I see the NOTICE from the library) :))))))

You should only have notices on for debugging....... So you'd pay for something to be fixed when you have the option to turn off........ Hell, I'd fix it for £100.........

funder7 commented 1 year ago

I dont know what else to add to the library, I think it is good as is and further "improvements" less likely will bring anything major anymore. I have to sit to fix php8 related deprecation notices with a backwards compatibility, this is so far the only thing in my todo

Sure, I was referring to fixing any warning to make it fully compatible with php 8.x, no need to add other functionalities IMHO.