search

ThingEngineering / wowthing-collector

WoW addon that collects data for WoWthing
MIT License
7 stars 3 forks source link

Realm info not working with non-english realm #5

Closed Leomaradan closed 2 years ago

Leomaradan commented 2 years ago

It seem that the LibRealmInfo:GetRealmInfoByUnit query on line 515 does not return any information

local _, realm, _, _, _, _, region, _, _, realmEnglish = LibRealmInfo:GetRealmInfoByUnit("player")

The realm and realmEnglish are nil, so the addon crash on the line 517

I'm on a French client

Leomaradan commented 2 years ago

The PR https://github.com/janekjl/LibRealmInfo/pull/3/commits on LibRealmInfo Repo seems to correct the issue

madcowfred commented 2 years ago

Applied that PR in v9.2.0.8, let me know if that fixes things for you

Leomaradan commented 2 years ago

Hi, this it perfect, thank you :)