search

ThingPulse / esp8266-oled-ssd1306

Driver for the SSD1306 and SH1106 based 128x64, 128x32, 64x48 pixel OLED display running on ESP8266/ESP32
https://thingpulse.com
Other
2k stars 638 forks source link

Added clearPixel(x,y) function #247

Closed szczys closed 5 years ago

szczys commented 5 years ago

I wanted the ability to clear a single pixel. I believe the INVERSE case works (same code as setPixel) but I have not tested.

helmut64 commented 5 years ago

I created a branch of the OLED library and added a lot of enhancements including mbed-os support in addition to Arduino support. All enhancements should be backward compatible. As ThingPulse does not work on merges/enhancements for some time, I added your enhancement to my branch: https://github.com/helmut64/OLED_SSD1306/tree/mbed_os_support

I merged your pull request into my branch (mbed_os_support ) and hope that my branch gets adapted by ThingPulse, otherwise I continue with the OLED library on github account.

Your clearPixel() is a good enhancements to have a clean API for this.

marcelstoer commented 5 years ago

Thanks for the improvements @helmut64. We sure appreciate them and please keep 'em coming 😄We prefer for you to create PRs here over you having to maintain your own fork.

As ThingPulse does not work on merges/enhancements for some time

That is true and I'm sorry about it. I already approved this one two weeks ago - just waiting for @squix78 for a second opinion.