search

ThingPulse / esp8266-oled-ssd1306

Driver for the SSD1306 and SH1106 based 128x64, 128x32, 64x48 pixel OLED display running on ESP8266/ESP32
https://thingpulse.com
Other
2k stars 638 forks source link

Revert optimizations for multiplication and division operations for 2,4,8. #258

Closed ElderJoy closed 4 years ago

marcelstoer commented 4 years ago

Looks good to me, thanks.

@DaveSprague @helmut64 I won't be able to test this on hardware for a while. Please comment here if you're happy with this.

helmut64 commented 4 years ago

This look fine for me.

DaveSprague commented 4 years ago

I checked it also and it looks correct to me as well.

Dave

On Tue, Oct 15, 2019 at 10:13 AM Helmut Tschemernjak < notifications@github.com> wrote:

This look fine for me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ThingPulse/esp8266-oled-ssd1306/pull/258?email_source=notifications&email_token=AALBSCUPHFDVZSVSLAPRIE3QOXFXBA5CNFSM4JA25CF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBI5F4I#issuecomment-542233329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBSCS2CPPOELISZST4V3DQOXFXBANCNFSM4JA25CFQ .