Fixed and improved circles + keywords

ThingPulse / esp8266-oled-ssd1306

Driver for the SSD1306 and SH1106 based 128x64, 128x32, 64x48 pixel OLED display running on ESP8266/ESP32

https://thingpulse.com

Other

1.99k stars 637 forks source link

Closed NoobTracker closed 4 years ago

NoobTracker commented 4 years ago

This version contains all the improvements of the other three versions: Improved circles, even more improved circles and rings and keywords.

NoobTracker commented 4 years ago

Is there anything wrong with this version?

marcelstoer commented 4 years ago

The same issue(s) as with your previous PRs: https://github.com/ThingPulse/esp8266-oled-ssd1306/pull/284/files. As far as Git is concerned you replaced the entire OLEDDisplay.h and .cpp.

NoobTracker commented 4 years ago

Yes, but it will be very difficult to find the lines affected and then replace them. I could try, but reluctant.

NoobTracker commented 4 years ago

Can you reject this pull request so that I can create a new version? I don't know how to delete your own forked version ...