search

ThingPulse / esp8266-oled-ssd1306

Driver for the SSD1306 and SH1106 based 128x64, 128x32, 64x48 pixel OLED display running on ESP8266/ESP32
https://thingpulse.com
Other
1.99k stars 637 forks source link

Adds support for also running on NRF52 targets #291

Closed geeksville closed 4 years ago

geeksville commented 4 years ago

(I just updated this old change based on current master and put it in a separate feature branch)

ESP32 targets are still supported (my project targets both)

Backstory here: https://github.com/ThingPulse/esp8266-oled-ssd1306/pull/277

geeksville commented 4 years ago

easier to view here: https://github.com/ThingPulse/esp8266-oled-ssd1306/pull/291/files. If you would prefer me to squash into one commit I can do that.

marcelstoer commented 4 years ago

If you would prefer me to squash into one commit I can do that.

No need to, thanks. We usually do a "Squash and merge" when we merge PRs.

Your video and my own very brief visual inspection is all I have to assess this. I don't have the hardware to test, but hey, LGTM.