Closed benoitm974 closed 4 years ago
Thanks for the feedback ! glad it worked.
I confirmed this fixes the issue. As you're at it please properly format the fragment as below (note the spaces)
#if !defined(ARDUINO_ARCH_ESP32)
this->_wire = &Wire;
#else
this->_wire = (_i2cBus == I2C_ONE) ? &Wire : &Wire1;
#endif
I confirmed this fixes the issue. As you're at it please properly format the fragment as below (note the spaces)
#if !defined(ARDUINO_ARCH_ESP32) this->_wire = &Wire; #else this->_wire = (_i2cBus == I2C_ONE) ? &Wire : &Wire1; #endif
Done.
Thanks for your continuous and amazing work!
can someone put out a new release please? cc @marcelstoer
I'm reluctant to cut a release without #296 being addressed. It appears to be a regression but I currently don't have a clue.
A platformio build on multiple boards would help, and I see there's a .travis.yml file present but the build is not triggered on travis somehow, there are no 'green ticks' behind the commits indicating it ran a travis build. Can you verify/look into this @marcelstoer? Make sure this repository has travis enabled? I can help looking into why builds fail, but only if I can see if they fail (hence travis needs to enabled).
I know, I looked into this the other day.
Travis CI is enabled and it does run for all commits (and PRs). The build badge at the top of the README at https://github.com/ThingPulse/esp8266-oled-ssd1306 is real. However, for whatever reason GitHub only triggers the builds, I verified this, but fails to pull in status information about those builds. I've seen this with some other projects I maintain and I even contacted GitHub support about this issue. They never replied but over there the feature came back after a while out of nowhere.
Ah I missed the badge. I'll open a pull request that tests against other boards. In theory, #296 should be caught by adding the correct device and a test case.
I'll open a pull request that tests against other boards.
See #300
Please note this is blind change as I don't have a non ESP32 arduino to test