search

ThingPulse / esp8266-oled-ssd1306

Driver for the SSD1306 and SH1106 based 128x64, 128x32, 64x48 pixel OLED display running on ESP8266/ESP32
https://thingpulse.com
Other
1.98k stars 636 forks source link

IMHO you may rename this good lib in esp-oled-ssd1306 #339

Closed rin67630 closed 3 years ago

rin67630 commented 3 years ago

it works perfectly on the ESP32 as well

Rotzbua commented 3 years ago

Renaming a git repository is danger zone, because it breaks links automated scripts and many more. Btw the name has been changed for a while in the library.json

marcelstoer commented 3 years ago

This repository has a long history. At its inception the world didn't have an ESP32 nor did ThingPulse Ltd. exist. Sure, in hindsight it wasn't a good idea to embed the MCU name in the library/repository name. Best we can do is to take this experience into account for future naming challenges. Btw, even 'esp-oled-ssd1306' wouldn't be appropriate now as the library works on ESP8266, ESP32, and Mbed-OS.

the name has been changed for a while in the library.json

Indeed, and that broke some backwards compatibility, too. Library managers aren't very well prepared for such moves.