ThingPulse / esp8266-oled-ssd1306

Driver for the SSD1306 and SH1106 based 128x64, 128x32, 64x48 pixel OLED display running on ESP8266/ESP32
https://thingpulse.com
Other
2.01k stars 638 forks source link

allow SPI display usage without CS pin #376

Closed seife closed 1 year ago

seife commented 1 year ago

If there is only one SPI device, the CS pin can be hardwired to ground. In that case, the CS pin setting should be ignored. Allow for that if CS is passed as "-1".

marcelstoer commented 1 year ago

Thanks, makes sense. Could you please use {} around the single-line if blocks and add notes to the README about this enhancement?

seife commented 1 year ago

sure, I did initially not find the SPI section in the README due to mistyping my search :-)

seife commented 1 year ago

JFTR: the README was fixed with the force-push from 2ea8d84 to e6b81a2 on Nov 29 already ;-)