SSD1306Wire.h, line 145 causes compilation error 'byte' is ambiguous

ThingPulse / esp8266-oled-ssd1306

Driver for the SSD1306 and SH1106 based 128x64, 128x32, 64x48 pixel OLED display running on ESP8266/ESP32

https://thingpulse.com

Other

1.98k stars 638 forks source link

SSD1306Wire.h, line 145 causes compilation error 'byte' is ambiguous #383

Closed neutralvibes closed 1 year ago

neutralvibes commented 1 year ago

Describe the bug Using 'byte' in SSD1306Wire.h, line 145 causes compilation error 'byte' is ambiguous error in my case.

        byte k = 0;
        for (y = minBoundY; y <= maxBoundY; y++) {
          for (x = minBoundX; x <= maxBoundX; x++) {
            if (k == 0) {

Expected behavior Use of uint8_t

        uint8_t k = 0;

Versions (please complete the following information):

Library: 4.40
Platform: ESP266 Arduino

marcelstoer commented 1 year ago

Even though I cannot reproduce this here it would make sense to replace the 4 places someone used byte with uint8_t. Seems related to https://github.com/esp8266/Arduino/pull/8090.