search

ThingPulse / esp8266-oled-ssd1306

Driver for the SSD1306 and SH1106 based 128x64, 128x32, 64x48 pixel OLED display running on ESP8266/ESP32
https://thingpulse.com
Other
1.98k stars 638 forks source link

Also accept char* pointer for fonts #393

Closed ropg closed 3 months ago

ropg commented 4 months ago

The squix.ch tool mentioned in the README maybe provided a uint8_t array at one point, or maybe we switched, but as it is now it provides a char array, so the font files from there don't work. This patch fixes that by converting the pointer we get.

marcelstoer commented 4 months ago

(thought I had commented before)

This looks sane to me and I'd merge it, but IMO it's for @squix78 to decide what the best course of action is at this point.

ropg commented 3 months ago

Any word? I think this should go in. As it is now you're pointing people to a site to make font files, and then they come back with files that don't work. It's so trivial to make both work.

Note that I changed it to point to the uint8_t version of setFont instead of just doing the work itself: that way #399 can just reset the logBuffer in one place.

ropg commented 3 months ago

👍