search

ThingPulse / esp8266-weather-station-color

ESP8266 Weather Station in Color using ILI9341 TFT 240x320 display
https://thingpulse.com/product/esp8266-wifi-color-display-kit-2-4/
MIT License
565 stars 221 forks source link

Moon phase graphic incorrect #143

Closed brianmiller1956 closed 2 years ago

brianmiller1956 commented 2 years ago

The moon phase graphic is incorrect, the text says full moon, I look out of the window and the full moon is present so it does calculate the moon age and illumination correctly but the graphic displayed shows nothing like this, it just shows effectively a letter C which is incorrect, can the graphic be synchronised with the text please. Otherwise a great project.

ionut531 commented 2 years ago

Yeah, I can confirm too. Even though the settings are correct, the moon phases are wrong. Currently, in my zone, the moon is 0.2 days, but it should be 28 days thus the graphing to be incorrect also.

VentoFahrer commented 2 years ago

https://support.thingpulse.com/1297/moon-icon-inverted-showing-black-fixed-esp8266-color-display

See the Last Post

marcelstoer commented 2 years ago

There's a potential fix pending in the fix/moon branch at https://github.com/ThingPulse/esp8266-weather-station-color/blob/fix/moon/esp8266-weather-station-color.ino. Soon to be merged.

brianmiller1956 commented 2 years ago

I have downloaded this update and it does look much better, the graphic matches what I see out of the window, many thanks for all the hard work, I appreciate the work involved.

marcelstoer commented 2 years ago

Thanks for the feedback, good to know. Later we might even be able to rotate the font character dynamically to give a more realistic representation of the moon.

brianmiller1956 commented 2 years ago

That sounds great, the icon really could do with a little more detail rather than just a flat disk.

Sent from my iPad Pro

On 20 Feb 2022, at 09:25, Marcel Stör @.***> wrote:

 Thanks for the feedback, good to know. Later we might even be able to rotate the font character dynamically to give a more realistic representation of the moon.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.