Update esp8266-weather-station-color.ino

ThingPulse / esp8266-weather-station-color

ESP8266 Weather Station in Color using ILI9341 TFT 240x320 display

https://thingpulse.com/product/esp8266-wifi-color-display-kit-2-4/

MIT License

565 stars 221 forks source link

Update esp8266-weather-station-color.ino #150

Closed TiVoHomeUser closed 2 years ago

TiVoHomeUser commented 2 years ago

Allow user to force a screen re-calibration
Break up the screen into 4 sections for navigation

Fixes #148.

[x] This PR is compliant with the other contributing guidelines as well (if not, please describe why).
[x] I have thoroughly tested my contribution.
[x] Should this code require changes to documentation I will contribute those to https://github.com/ThingPulse/docs.

\<Description of and rationale behind this PR>

marcelstoer commented 2 years ago

I just tested this myself and I still like your idea. Thanks!

For whatever reason my test device here has got top/bottom mixed up for the touch screen. Don't understand this yet as the whole point of the calibration procedure is to take care of this. Sigh...

I'll leave review comments right with the code.

TiVoHomeUser commented 2 years ago

Moved touch screen point selection to new changeScreen function. Commented out confusing screen selection debug output. changed unsigned 16 bit member variable screen to unsigned 8 bit.

TiVoHomeUser commented 2 years ago

marcelstoer: I see the size I used was for the display object not the touch screen your changes with the fixed size looks good.

marcelstoer commented 2 years ago

Thanks again for the inspiration and the first implementation! https://twitter.com/thingpulse/status/1495371662270906369