search

ThingPulse / esp8266-weather-station

ESP8266 Weather Station library supporting OpenWeatherMap, Aeris and other sources
MIT License
1.07k stars 363 forks source link

A ^ #123

Closed tedbmoss closed 6 years ago

tedbmoss commented 6 years ago

there is an A with a hat on it in line 386 for local temp before the F or C . what is this for? I removed it. I can't see where you have the q to ask for weather data, it is there and works, but I can't tell where it comes from, a font number perhaps? I would like to replace it with id so I can call my local weather, Peoria, AZ since Peoria is ambiguous.

ccpetersen commented 6 years ago

The "q=" is hardcoded in the OpenWeatherMapCurrent.cpp and OpenWeatherMapForecast.ccp around line 35. Change it to "id=". and you should be good to go.

marcelstoer commented 6 years ago

there is an A with a hat on it in line 386 for local temp before the F or C

In which file?

so I can call my local weather, Peoria, AZ since Peoria is ambiguous.

I created PR #122 for exactly that problem.

marcelstoer commented 6 years ago

This appears to be about https://github.com/ThingPulse/esp8266-weather-station-color/blob/master/esp8266-weather-station-color.ino#L386. Works fine in all editors and all platforms we tested (Windows/Mac).

tedbmoss commented 6 years ago

In reference to the degree symbols C and F on line 386 in main file. Sorry about this, but the file published has a different symbol in it than the (later) one in the referenced file which works fine. I copied it from the file which you referenced and it does as you say, but the one published does not. I don't know how to say this to make it clearer, I know it could be said better.