Fix compilation error in MetOfficeClient.cpp

[vlastahajek]

Maybe fixes issue #198.

• [X] This PR is compliant with the other contributing guidelines as well (if not, please describe why).
• [X] I have thoroughly tested my contribution.
• [X] Should this code require changes to documentation I will contribute those to https://github.com/ThingPulse/docs.

With compiler option -Werror=return-type:

C:\Users\vlast\OneDrive\Dokumenty\Arduino\libraries\esp8266-weather-station\src\MetOfficeClient.cpp: In member function 'String MetOfficeClient::getWeatherIconName(String)':
C:\Users\vlast\OneDrive\Dokumenty\Arduino\libraries\esp8266-weather-station\src\MetOfficeClient.cpp:463:1: error: control reaches end of non-void function [-Werror=return-type]
463 | }

[marcelstoer]

To make sure we catch similar issues before the code is released, that compiler switch should be enabled for CI builds?

[vlastahajek]

I would recommend this. I don't use PlatformIO. This was added automatically by Arduino, most probably by changing the setting to show all warnings. However, It looks like that it is included because I received an email with failed builds in master with the exactly the same error.

[marcelstoer]

It looks like that it is included because I received an email with failed builds in master with the exactly the same error.

Appears to be a new behavior as the CI build passed previously. Now it doesn't: https://github.com/ThingPulse/esp8266-weather-station/runs/3170920198 This is likely because we neither pin the PlatformIO version nor the platform & framework versions.