search

ThinkInvis / RoR2-Admiral

A mod for Risk of Rain 2.
GNU General Public License v3.0
1 stars 1 forks source link

Orbital Jump Pad nullref related to Risky Artifacts #28

Closed Moffein closed 2 years ago

Moffein commented 2 years ago

Risky Artifacts seems to cause Admiral to nullref when setting up the Orbital Jump Pads. The skill seems to work fine in game, but it would probably be good to fix this just in case there's anything unexpected related to it.

If there's anything that needs to be done on my end regarding this, let me know.

LogOutput.log

ThinkInvis commented 2 years ago

This is likely because the setup copies of prefabs are awakening during load, as they're only created with GameObject.Instantiate and not R2API.PrefabAPI.InstantiateClone. I'm updating the code for that to a better method that should avoid this (Addressables + InstantiateClone x2), but whatever Risky Artifacts is doing could probably stand to have more null safety added as well.

ThinkInvis commented 2 years ago

Should be fixed in de46abad35f390c12f13cfb78325a2ccc727fbb9.