ThinkInvis / RoR2-ClassicItems

A mod for Risk of Rain 2.
GNU General Public License v3.0
3 stars 6 forks source link

Incorrect Beating Embryo multiproc chance calculation #103

Closed rainbowism closed 2 years ago

rainbowism commented 2 years ago

Describe the Bug

Beating Embryo's multiproc chance calculation is incorrect.

To Reproduce

Steps to reproduce the behavior:

  1. Enable Embryo.CanMultiproc and set Embryo.ProcChance to a value < 100%.
  2. Use an equipment in game with less than 100% total chance.

Expected Behavior

Partial chances should have the ability to proc an additional effect.

Additional Context

The bug is located here.

Line 258 and 270 shouldn't have a / 100 in the latter part of the calculation, using a scale from 0-100 rather than 0.0-1.0 like the non-multiproc version.