search

ThinkInvis / RoR2-ClassicItems

A mod for Risk of Rain 2.
GNU General Public License v3.0
3 stars 6 forks source link

Life Savings not functioning on Nemforcer (Bug) #72

Closed Coffe-e closed 2 years ago

Coffe-e commented 3 years ago

Describe the Bug

When you pick up a stack of Lifesavings as Nemforcer from the Enforcer mod, he doesn't gain any money.

To Reproduce

Steps to reproduce the behavior:

  1. Start a run as Nemforcer
  2. Give yourself lifesavings

Expected Behavior

Giving money at it's disclosed rate

Console Log

LogOutput.log

cheeeeeeeeeen commented 3 years ago

@Coffe-e Would this really be related to Life Savings? It works on other survivors, so why not Nemforcer? I think Nemforcer has the bug...

Ulivax commented 3 years ago

@cheeeeeeeeeen This bug can also be applied to the Paladin playable character (rob-PaladinMod-1.0.9) as well. As you say, probably to do with handling modded characters? Not sure about Bandit etc.

Edit: FALSE Tried with Bandit, also no money gain from Life Savings

Edit 2: Tried using artifact of command on Life Savings with various modded characters, here's my list: Life Savings work on: Bandit, Gunslinger, Enforcer, Miner and all Vanilla characters. Life Savings doesn't work on: Paladin

ThinkInvis commented 3 years ago

I'll try to pin this down after work on #77 is done, but it sounds like this is probably an issue with how those modded characters are set up (e.g. they may fail to have the same object structure as vanilla characters).

ThinkInvis commented 2 years ago

AFAIK this wound up being a ShareSuite bug (modded characters had to provide compat code and wouldn't work out-of-the-box if installed alongside ShareSuite).