search

ThinkInvis / RoR2-TILER2

A library mod for Risk of Rain 2.
GNU General Public License v3.0
2 stars 1 forks source link

[Feature Request] Way to remove items from logbook if disabled? #16

Closed Coffe-e closed 2 years ago

Coffe-e commented 3 years ago

Is your feature request related to a problem? Please describe.

I kinda hate seeing the disabled items in the logbook

Describe the solution you'd like

I've heard people like duckduckgrey throw around the idea of making the disabled items "Notier" (I think the elite equipment, artifact keys, and etc use them) to remove them from the logbook

Describe alternatives you've considered

Unsure of alternatives, but it would be nice

ThinkInvis commented 3 years ago

That's outside the scope of ClassicItems specifically, and would ideally be a TILER2 feature. Transferring issue.

ThinkInvis commented 3 years ago

Disabling items used to work this way, but I discarded it in favor of allowing items to be disabled/enabled at runtime (instead of only while the game is closed). Getting both of these to happen simultaneously is likely a lot more difficult than just switching the item's tier, but it may still be possible.

ThinkInvis commented 3 years ago

Progress as of https://github.com/ThinkInvis/RoR2-TILER2/commit/a8d8fd880172fa681d63a06dd38936cd7bdf1575: disabled items/equipment are now hidden in Command droplets. Logbook is looking a lot more complicated.

ThinkInvis commented 2 years ago

Mostly fixed in c8a60159e92efe4632921463384193318de17566. However, items disabled/enabled while the game is running will not update the logbook until the game is restarted. Opening a new issue for this bug, which is much harder to fix than hiding/showing during game startup -- logbook data is built once only and stored in a bunch of different places (incl. a catalog which should probably not be messed with).