ThinkInvis / RoR2-TILER2

A library mod for Risk of Rain 2.
GNU General Public License v3.0
2 stars 1 forks source link

Changing item/equipment disable status midgame does not update logbook #23

Open ThinkInvis opened 2 years ago

ThinkInvis commented 2 years ago

Describe the Bug

Disabling/enabling an item or equipment while the game is running should cause its entry to disappear/appear in the logbook, respectively. Due to code limitations (relevant data is stored in ReadOnlyCollections in ViewablesCatalog), this has not been accomplished yet.

To Reproduce

  1. Launch the game with TILER2 and a dependent item mod installed (with all items enabled)
  2. Open the logbook menu
  3. Observe a modded item in the logbook
  4. Disable the modded item (via console ncfg set itemname enabled false)
  5. Observe that the modded item's logbook entry has not disappeared, even after closing and reopening the logbook
  6. Restart the game
  7. Open the logbook menu
  8. Observe that the modded item's logbook entry is hidden

Expected Behavior

Logbook entry hide state should be refreshed upon opening the logbook, instead of only when the game is loaded. Ideally, a change in hide state should reload the logbook if it's already open.