ThinkInvis / RoR2-TinkersSatchel

A mod for Risk of Rain 2.
GNU General Public License v3.0
4 stars 4 forks source link

Add Shock to Triskellion Brooch #25

Closed gaforb closed 2 years ago

gaforb commented 2 years ago

Instead of stun why not have it apply shock, completing the elemental trifecta and adding a much-needed source of shock to the game. Or just add shock as another thing it can proc in addition to stun, but that does clash with the "Tri" aspect

Also, some adjustments to the config seem reasonable:

ThinkInvis commented 2 years ago

Triskelion Brooch is an Artificer-themed item: Artificer has stun, freeze, and ignite available through skills -- even all at once -- but not shock. All of the former are also available from at least one item source, while the latter only exists on Captain M2; so switching stun to shock would reduce this item's effectiveness by 1/3 on any other character, no matter how many other items they have. I'll make shock count as stun for the purposes of this item, but that's the most I'm willing to change on this front.

The proc chance isn't implemented correctly: it should be a 0-100 value (as Util.CheckRoll uses), but it's incorrectly clamped to/displayed in logbook as 0-1 at the moment, and not actually checked before proccing in some cases.

ThinkInvis commented 2 years ago

Fixed/implemented in above commits.