ThinkInvis / RoR2-TinkersSatchel

A mod for Risk of Rain 2.
GNU General Public License v3.0
4 stars 4 forks source link

Item Drone + Mystic's items incompatability. #33

Closed Coffe-e closed 2 years ago

Coffe-e commented 2 years ago

Describe the Bug

If an item drone obtains marwan's ash by any means (being summoned in, giving it the item), and then it levels up, it will keep giving copies of marwan's ash to the player, resulting in infinite stacks of marwan's ash.

To Reproduce

Steps to reproduce the behavior:

  1. Start a run
  2. Obtain Marwan's ash
  3. give marwan's ash to an item drone
  4. level up to the level that marwan's ash turns into marwan's light

Expected Behavior

to just give one fake copy of marwan's ash/light/weapon

Console Log

LogOutput.log

Additional Context

Add any other context about the problem here (screenshots, etc.).

ThinkInvis commented 2 years ago

Mystic's Items needs to add a soft dependency on TILER2 and ignore fake items while performing an upgrade. There will be an update to TILER2 soon that makes this easier (ThinkInvis/RoR2-TILER2@191aa6b3f0d359fe6d5023b29988d6858d11a3a1).

ThinkInvis commented 2 years ago

Fixed in https://github.com/TheMysticSword/MysticsItems/commit/3870c4cefc1289be4d0a4bc9769f7320f633ae20.