search

ThinkOpenly / sail-riscv

Sail RISC-V model
Other
11 stars 14 forks source link

tags for the instructions. #10

Closed Sanket-0510 closed 6 months ago

Sanket-0510 commented 7 months ago

implements #5 the way described by issue #4.

I have tried covering tags for extension "C". In last PR I was working on main branch hence overlooked extension function and some other check made by you. This PR will hopefully overcome all those mistakes and will do the checks for extension C.

Sanket-0510 commented 7 months ago

A few minor comments, but otherwise looks really close. Have you attempted to test this by running with it? (That should've caught at least one of the issues.)

All tests passed successfully on my side, I think we are good to go with this for extension C.

Screenshot from 2024-01-24 11-45-23

ThinkOpenly commented 6 months ago

@Sanket-0510, I reformatted your patches a bit, squashed them, committed into a fresh branch of my own, and merged them in PR #12. You are still listed as the author. I am just the committer. Thank you for your efforts here!

ThinkOpenly commented 1 month ago

FYI, this commit and other related "extension tagging" commits have been merged upstream. https://github.com/riscv/sail-riscv/commit/6492f8c728d2bf121521a5765f3e0613c08e5f2c. Congratulations, and thank you for your efforts! :tada: