FIX: [Makefile] command is echoed out to stdout

ThinkOpenly / sail-riscv

Sail RISC-V model

Other

11 stars 14 forks source link

FIX: [Makefile] command is echoed out to stdout #14

Closed snapdgn closed 5 months ago

snapdgn commented 5 months ago

When running make json, it outputs a valid json without any debug outputs , EXCEPT it echoes out the command too, thus messing up the json representation.

Refer the Screenshot below for clarity.

This PR fixes it so that no hand-editing is required.

P.S - This was such a small change, that I didn't think creating a new branch was necessary. Let me know if I should do that in future.

Thanks

snapdgn commented 5 months ago

@ThinkOpenly , Sorry, I forgot to ping you. Can this be closed now?

ThinkOpenly commented 5 months ago

Can this be closed now?

I'm being pedantic, but let's follow "generally accepted practices" for some important open source projects and limit the width of the commit message to less than 80 characters. Could you break the final line of your commit message before 80 characters? Thanks!

snapdgn commented 5 months ago

Can this be closed now?

I'm being pedantic, but let's follow "generally accepted practices" for some important open source projects and limit the width of the commit message to less than 80 characters. Could you break the final line of your commit message before 80 characters? Thanks!

Sorry, I had wrapping turned on in my vim configs at 80 chars, I don't know why this happened, maybe a misconfiguration. Will keep this in mind from next time. Let me know if this looks good now.