Closed jriyyya closed 5 months ago
Thanks, @jriyyya! The code looks fine to me. It compiles and produces the same output as before, as expected. You've marked this PR as "draft", so I will hold off merging it for now.
Really minor comments:
have<extension-name>()
to extension("<extension-name")
to facilitate parsing." or something like that.With or without any of those suggestions implemented (as I said it's fine as-is), remove the "draft" marking when you are ready for me to merge this!
Thanks for the Review. I was actually planning to continue this PR and further add extension function for D and F. We can also open another PR for the same, So removing the draft here.
Sorry about the commit message. Should Squash these three commits into to a single commit as "Utilize extension() instead of haveZdinx(), haveZfinx(), haveZhinx" ?
I thought of adding a description when I would have removed the draft tag, I have added it now. I will keep in mind to add it beforehand next time 😅.
grepping through the code, I see a need to make similar changes for haveSupMode
, haveUsrMode
, haveNExt
, haveZmmul
, and haveZkr
(at least).
(A good test might be to comment out all of the have*
functions in model/riscv_sys_regs.sail
, and see what errors are produced when building. I have not done this.)
For now, what you have posted is great. I'll merge this, and you can continue with those, at your option, when you are able. Thanks, again!
(A good test might be to comment out all of the
have*
functions inmodel/riscv_sys_regs.sail
, and see what errors are produced when building. I have not done this.)
Quite a nice idea, I will give it a try!
This PR aims to continue the remaining work from commit https://github.com/ThinkOpenly/sail-riscv/commit/7c1eae725f945a30a41ab84eee000ec85dcafb0f of issue #4 converting all uses of haveZdinx(), haveZhinx(), haveZfinx() to extension("Zdinx"), extension("Zhinx"), extension("Zfinx") respectively to facilitate parsing.