search

ThinkOpenly / sail-riscv

Sail RISC-V model
Other
12 stars 14 forks source link

Add tags to all instructions also make them to clearly express their purpose #9

Closed Sanket-0510 closed 9 months ago

Sanket-0510 commented 9 months ago

Implements #4 #5

I have defined a helper function name extension in riscv_insts_helper and have included this function to check the extensions of the functions in riscv_insts_*.sail right now it covers "A" and "C" extensions but I will add others also after the feedback.

@ThinkOpenly tell me if I am on right track or not, I'll do the required changes in further commits.

Sanket-0510 commented 9 months ago

@ThinkOpenly will you please resolve the conflicts and also review the extension function, I have added function into seperate file but I guess we can define the function in riscv_sys_regs.sail only.

correction - I missed out on the defined function, as I was working on the main branch only no need to define that again.

Sanket-0510 commented 9 months ago

I have made the required changes through PR #10 which right now covers check for extension C. In this PR, Facing conflicts as I overlooked the JSON branch. closing this PR.