ThinkOpenly / sail

Sail architecture definition language
Other
10 stars 11 forks source link

`jalr` needs parens #1

Closed ThinkOpenly closed 8 months ago

ThinkOpenly commented 11 months ago

Current assembly syntax for jalr (and perhaps others) does not include parentheses, implying that the representation should be:

jalr rd,rs1,imm

instead of what is expressed in examples in The RISC-V Instruction Set Manual in various examples:

jalr rd,imm12(ra)
ThinkOpenly commented 10 months ago

https://github.com/riscv/sail-riscv/issues/344

Myrausman commented 8 months ago

Hi @ThinkOpenly , I just wanted to confirm if this issue is still open. The link above suggests that it's completed

ThinkOpenly commented 8 months ago

I just wanted to confirm if this issue is still open. The link above suggests that it's completed

Good catch. This issue has indeed been resolved.