search

ThinkOpenly / sail

Sail architecture definition language
Other
10 stars 11 forks source link

JSON: Extract register information #27

Closed AbhinavMir closed 3 months ago

AbhinavMir commented 3 months ago

for #10 Adding a new PR because the previous one was getting stale to the point of being too messy to rebase

AbhinavMir commented 3 months ago

@ThinkOpenly Indeed I marked this as ready for review when it should've been in draft, I've taken your inputs and made some modifications. Please let me know if they're satisfactory. I've removed sorting and unused variables. I had switched to using a plain vi since VS Code was forcing it's own linter which was getting annoying and I must've missed that unused variable.

ThinkOpenly commented 3 months ago

Looks good. Did you run dune fmt?

ThinkOpenly commented 3 months ago

The "Close with comment" button is very close to the "Comment" button. Sorry about that. Check formatting using dune fmt, then let's get this merged.

ThinkOpenly commented 3 months ago

Oh! I guess the GitHub actions run dune fmt automatically. Duh. So, ignore my previous comments. I'll wait for the checks to complete, then merge this.

github-actions[bot] commented 3 months ago

Test Results

    9 files  ±0     20 suites  ±0   0s :stopwatch: ±0s   615 tests ±0    615 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 978 runs  ±0  1 977 :white_check_mark: ±0  1 :zzz: ±0  0 :x: ±0 

Results for commit e4222138. ± Comparison against base commit 7ad136c5.