Add MS SQL Server - Githubissues

ThinkR-open / bank

Alternative caching backends for `{memoise}` & `{shiny}`.

Other

12 stars 2 forks source link

Add MS SQL Server #8

Closed ggpinto closed 2 years ago

ggpinto commented 2 years ago

Hi,

I have implemented MS SQL Server as a backend (probably there was a better way, but I am not that good with R6 yet). What I did:

Created cache_ms_sql based on cache_ms_postgres
Created tests for cache_ms_sql based on cache_ms_postgres
Updated the documentation

ColinFay commented 2 years ago

Planning on reviewing this PR next week, will try on monday.

ggpinto commented 2 years ago

Next week I’ll have more time and can redo it inheriting a class instead of rewriting it, if it can wait a bit I might come back with a better solution 😊

ggpinto commented 2 years ago

Hi Colin, I don’t think I can use inheritance without having to change the code for PostgreSQL too, it would be a more elegant solution (mainly to detect if the needed packages are installed and to deal with different SQL data types). Just tell me what you prefer.

ggpinto commented 2 years ago

With free time I have tried a new approach (that can maybe used as parent for all SQL classes in the future), I am sending a new PR