search

ThinkR-open / checkhelper

A package to help deal with devtools::check outputs
https://thinkr-open.github.io/checkhelper/
Other
34 stars 4 forks source link

unique(c(...)) instead of c(unique(...)) #10

Closed jtrecenti closed 3 years ago

jtrecenti commented 3 years ago

c(unique("a", "b")) gives an error

but

unique(c("a", "b")) is fine

statnmap commented 3 years ago

Thank you for your contribution. You're totally right.
Can you update the unit test accordingly and check again before submitting (devtools::check())?
I think here would be enough: https://github.com/ThinkR-open/checkhelper/blob/faa3c17309960a1e90e0f6a1930ca828119746fa/tests/testthat/test-checkhelper.R#L71 Thank you.

statnmap commented 3 years ago

Thank you for the PR !