search

ThinkR-open / checkhelper

A package to help deal with devtools::check outputs
https://thinkr-open.github.io/checkhelper/
Other
34 stars 4 forks source link

As a dev, I want to fix unit tests with function files in notes #23

Open statnmap opened 1 year ago

statnmap commented 1 year ago

This only appears on Actions for now.
Need to reproduce the problem locally to be able to fix it.

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure (test-checkhelper.R:34:3): get_no_visible works ─────────────────────
globals$globalVariables$fun not equal to c(...).
9/9 mismatches
x[1]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348c18e5542c/checkpackage.R
x[1]: check/00_pkg_src/checkpackage/R/function.R:7-12) my_long_fun_name_for_mult
x[1]: iple_lines_globals"
y[1]: "my_long_fun_name_for_multiple_lines_globals"

x[2]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348c18e5542c/checkpackage.R
x[2]: check/00_pkg_src/checkpackage/R/function.R:7-12) my_long_fun_name_for_mult
x[2]: iple_lines_globals"
y[2]: "my_long_fun_name_for_multiple_lines_globals"

x[3]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348c18e5542c/checkpackage.R
x[3]: check/00_pkg_src/checkpackage/R/function.R:7-12) my_long_fun_name_for_mult
x[3]: iple_lines_globals"
y[3]: "my_long_fun_name_for_multiple_lines_globals"

x[4]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348c18e5542c/checkpackage.R
x[4]: check/00_pkg_src/checkpackage/R/function.R:19-24) my_plot"
y[4]: "my_plot"

x[5]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348c18e5542c/checkpackage.R
x[5]: check/00_pkg_src/checkpackage/R/function.R:19-24) my_plot"
y[5]: "my_plot"
── Failure (test-checkhelper.R:47:3): print_outputs works ──────────────────────
print_outputs$liste_funs not equal to "--- Functions to add in NAMESPACE (with @importFrom ?) ---\n\nmy_long_fun_name_for_multiple_lines_globals: %>%, aes, geom_point, ggplot, mutate\nmy_plot: %>%, aes, geom_point, ggplot, mutate\nmy_plot_rdname: %>%, aes, geom_point, ggplot, mutate\n".
1/1 mismatches
x[1]: "--- Functions to add in NAMESPACE (with @importFrom ?) ---\n\n  (/tmp/Rtm
x[1]: pkW3scz/working_dir/RtmpMNu2An/file348c18e5542c/checkpackage.Rcheck/00_pkg
x[1]: _src/checkpackage/R/function.R:19-24) my_plot: aes, geom_point, ggplot, mu
x[1]: tate\n  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348c18e5542c/checkpack
x[1]: age.Rcheck/00_pkg_src/checkpackage/R/function.R:19-24) my_plot_rdname: ...
y[1]: "--- Functions to add in NAMESPACE (with @importFrom ?) ---\n\nmy_long_fun
y[1]: _name_for_multiple_lines_globals: %>%, aes, geom_point, ggplot, mutate\nmy
y[1]: _plot: %>%, aes, geom_point, ggplot, mutate\nmy_plot_rdname: %>%, aes, geo
y[1]: m_point, ggplot, mutate\n"
── Failure (test-checkhelper.R:51:3): print_outputs works ──────────────────────
print_outputs$liste_globals not equal to "--- Potential GlobalVariables ---\n-- code to copy to your R/globals.R file --\n\nglobalVariables(unique(c(\n# my_long_fun_name_for_multiple_lines_globals: \n\"new_col\", \"x\", \"y\", \n# my_plot: \n\"new_col2\", \"x\", \"y\", \n# my_plot_rdname: \n\"new_col2\", \"x\", \"y\"\n)))".
1/1 mismatches
x[1]: "--- Potential GlobalVariables ---\n-- code to copy to your R/globals.R fi
x[1]: le --\n\nglobalVariables(unique(c(\n#   (/tmp/RtmpkW3scz/working_dir/RtmpM
x[1]: Nu2An/file348c18e5542c/checkpackage.Rcheck/00_pkg_src/checkpackage/R/funct
x[1]: ion.R:19-24) my_plot: \n\"new_col2\", \"x\", \"y\", \n#   (/tmp/RtmpkW3scz
x[1]: /working_dir/RtmpMNu2An/file348c18e5542c/checkpackage.Rcheck/00_pkg_src...
y[1]: "--- Potential GlobalVariables ---\n-- code to copy to your R/globals.R fi
y[1]: le --\n\nglobalVariables(unique(c(\n# my_long_fun_name_for_multiple_lines_
y[1]: globals: \n\"new_col\", \"x\", \"y\", \n# my_plot: \n\"new_col2\", \"x\", 
y[1]: \"y\", \n# my_plot_rdname: \n\"new_col2\", \"x\", \"y\"\n)))"
── Failure (test-checkhelper.R:93:3): notes from checks works ──────────────────
all(notes[["fun"]][2:9] == "my_long_fun_name_for_multiple_lines_globals") is not TRUE

`actual`:   FALSE
`expected`: TRUE 
── Failure (test-checkhelper.R:94:3): notes from checks works ──────────────────
all(notes[["fun"]][10:17] == "my_plot") is not TRUE

`actual`:   FALSE
`expected`: TRUE 
── Failure (test-checkhelper.R:95:3): notes from checks works ──────────────────
all(notes[["fun"]][18:25] == "my_plot_rdname") is not TRUE

`actual`:   FALSE
`expected`: TRUE 
── Failure (test-checkhelper.R:103:3): get_no_visible works after checks ───────
globals$globalVariables$fun not equal to c(...).
9/9 mismatches
x[1]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348ca3f0706/checkpackage.Rc
x[1]: heck/00_pkg_src/checkpackage/R/function.R:7-12) my_long_fun_name_for_multi
x[1]: ple_lines_globals"
y[1]: "my_long_fun_name_for_multiple_lines_globals"

x[2]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348ca3f0706/checkpackage.Rc
x[2]: heck/00_pkg_src/checkpackage/R/function.R:7-12) my_long_fun_name_for_multi
x[2]: ple_lines_globals"
y[2]: "my_long_fun_name_for_multiple_lines_globals"

x[3]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348ca3f0706/checkpackage.Rc
x[3]: heck/00_pkg_src/checkpackage/R/function.R:7-12) my_long_fun_name_for_multi
x[3]: ple_lines_globals"
y[3]: "my_long_fun_name_for_multiple_lines_globals"

x[4]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348ca3f0706/checkpackage.Rc
x[4]: heck/00_pkg_src/checkpackage/R/function.R:19-24) my_plot"
y[4]: "my_plot"

x[5]: "  (/tmp/RtmpkW3scz/working_dir/RtmpMNu2An/file348ca3f0706/checkpackage.Rc
x[5]: heck/00_pkg_src/checkpackage/R/function.R:19-24) my_plot"
y[5]: "my_plot"