ThinkR-open / dockerfiler

Easy Dockerfile Creation from R
https://thinkr-open.github.io/dockerfiler/
Other
176 stars 26 forks source link

Could not working `FROM` fields then fixed. #1

Closed uribo closed 6 years ago

uribo commented 6 years ago

Currently, both CRAN and GitHub versions had Dockerfile$new()'s FROM option were unable to change.

``` r install.packages("dockerfiler") #> #> The downloaded binary packages are in #> /var/folders/0x/mb63hycs4k30_7httqyxh2rr0000gn/T//RtmplVlPBc/downloaded_packages library(dockerfiler) my_dock <- Dockerfile$new(FROM = "rocker/tidyverse") my_dock #> FROM rocker/r-base ``` ``` r remotes::install_github("ColinFay/dockerfiler") #> Using github PAT from envvar GITHUB_PAT #> Downloading GitHub repo ColinFay/dockerfiler@master #> Skipping 1 packages ahead of CRAN: rlang library(dockerfiler) my_dock <- Dockerfile$new(FROM = "rocker/tidyverse") my_dock #> FROM rocker/r-base ``` Created on 2018-03-13 by the [reprex package](http://reprex.tidyverse.org) (v0.2.0).

This patch will allow to specify any dokcer image.

``` r library(dockerfiler) my_dock <- Dockerfile$new(FROM = "rocker/tidyverse") my_dock #> FROM rocker/tidyverse ``` Created on 2018-03-13 by the [reprex package](http://reprex.tidyverse.org) (v0.2.0).

p.s. Thanks for nice package development. I’m fanboy R and Docker too 🐳

ColinFay commented 6 years ago

Thanks @uribo for the patch !