Closed psolymos closed 2 years ago
Hey @psolymos,
thanks for this !
yes, this indeed belong here and I suppose the logic you suggested (check if there is an Rbuildignore and if yes add to it) will be the correct one.
Happy to review a PR if you want to do it :)
PR #37 closes this.
When using the
golem::add_dockerfile()
functionality, a.dockerignore
is created, which is great. However, this should be added to the.Rbuildignore
file as^\.dockerignore$
otherwise R CMD check complains. This is a problem when used in an R package context and not when used running scripts, so maybe I should file this issue for {golem}, but because thedockerfiler::docker_ignore_add
is responsible, I thought it belongs here.Suggested behavior:
.Rbuildignore
file exists.dockerignore
to itLet me know what you think, and if this issue belongs here, I am happy to work on a PR.