ThinkR-open / dockerfiler

Easy Dockerfile Creation from R
https://thinkr-open.github.io/dockerfiler/
Other
176 stars 27 forks source link

Install quarto-cli system dependency when needed #42

Closed gueyenono closed 2 years ago

gueyenono commented 2 years ago

I recently learned about the extremely useful function golem::add_dockerfile_with_renv(). It does a wonderful job creating dockerfiles for the building of images containing the necessary system dependencies.

In my current app, a call to quarto::quarto_render(), which depends on quarto-cli is made. As things stand now, the aforementioned golem function does not detect this dependency. This causes the app to crash when the document rendering is initiated. Quarto is currently bleeding-edge so it is normal that it is not yet included in other packages. Please consider accounting for the quarto-cli dependency in golem.

Thank you.

statnmap commented 2 years ago

Hi, @gueyenono Thanks for using {golem}

In add_dockerfile_with_renv(), we're using {pak} to take care of system dependencies, which itself relies on https://github.com/rstudio/r-system-requirements
So as soon as the {quarto} system requirements are added to the list, they should be available in the Dockerfile here.

I close this issue as it is not about {dockerfiler}. You may want to open an issue there: https://github.com/rstudio/r-system-requirements/issues