search

ThinkR-open / dockerfiler

Easy Dockerfile Creation from R
https://thinkr-open.github.io/dockerfiler/
Other
169 stars 25 forks source link

[BUG] `golem::add_dockerfile_with_renv` appends version to user-specified `FROM` argument #53

Closed yogat3ch closed 1 month ago

yogat3ch commented 1 year ago

Describe the bug A user-specified FROM argument is appended with the R Version.

To Reproduce

golem::add_dockerfile_with_renv(
          output_dir = "deploy",
# A specific version is specified
          from = "rocker/r-ver:4.2.1@sha256:3e3f21d75482c5c66e122188ae88ad5c89ca24f5202dd07f69c623b3c8af7e80"
        )

Expected behavior If a user specifies the FROM argument, it should be substituted, unmodified, in the FROM cmd, without appending the R version.

Alternative solution And/or add another argument for the R Version with default arguments such that it can be set to NULL when FROM is provided.

Screenshots The FROM command ends up like this: FROM rocker/r-ver:4.2.1@sha256:3e3f21d75482c5c66e122188ae88ad5c89ca24f5202dd07f69c623b3c8af7e80:4.2.1

session_info ``` ─ Session info ──────────────────────────────────────────────────────────────────────────── setting value version R version 4.2.1 (2022-06-23) os macOS Ventura 13.2.1 system aarch64, darwin20 ui RStudio language (EN) collate en_US.UTF-8 ctype en_US.UTF-8 tz America/New_York date 2023-03-01 rstudio 2022.12.0+353 Elsbeth Geranium (desktop) pandoc NA ─ Packages ──────────────────────────────────────────────────────────────────────────────── ! package * version date (UTC) lib source cachem 1.0.6 2021-08-19 [1] CRAN (R 4.2.0) callr 3.7.2 2022-08-22 [1] CRAN (R 4.2.1) P cli 3.6.0 2023-01-09 [?] CRAN (R 4.2.0) crayon 1.5.2 2022-09-29 [1] CRAN (R 4.2.1) devtools 2.4.5 2022-10-11 [1] CRAN (R 4.2.0) P digest 0.6.31 2022-12-11 [?] CRAN (R 4.2.0) P ellipsis 0.3.2 2021-04-29 [?] CRAN (R 4.2.0) P fansi 1.0.3 2022-03-24 [?] CRAN (R 4.2.0) fastmap 1.1.0 2021-01-25 [1] CRAN (R 4.2.0) VP fs 1.5.2 2023-02-06 [?] CRAN (R 4.2.0) (on disk 1.6.1) P glue 1.6.2 2022-02-24 [?] CRAN (R 4.2.0) P htmltools 0.5.4 2022-12-07 [?] CRAN (R 4.2.0) htmlwidgets 1.5.4 2021-09-08 [1] CRAN (R 4.2.0) P httpuv 1.6.8 2023-01-12 [?] CRAN (R 4.2.0) later 1.3.0 2021-08-18 [1] CRAN (R 4.2.0) P lifecycle 1.0.3 2022-10-07 [?] CRAN (R 4.2.0) P magrittr 2.0.3 2022-03-30 [?] CRAN (R 4.2.0) memoise 2.0.1 2021-11-26 [1] CRAN (R 4.2.0) mime 0.12 2021-09-28 [1] CRAN (R 4.2.0) miniUI 0.1.1.1 2018-05-18 [1] CRAN (R 4.2.0) P pillar 1.8.1 2022-08-19 [?] CRAN (R 4.2.0) pkgbuild 1.3.1 2021-12-20 [1] CRAN (R 4.2.0) P pkgconfig 2.0.3 2019-09-22 [?] CRAN (R 4.2.0) pkgload 1.3.0 2022-06-27 [1] CRAN (R 4.2.0) P plyr 1.8.7 2022-03-24 [?] CRAN (R 4.2.0) P prettyunits 1.1.1 2020-01-24 [?] CRAN (R 4.2.0) processx 3.7.0 2022-07-07 [1] CRAN (R 4.2.0) profvis 0.3.7 2020-11-02 [1] CRAN (R 4.2.0) promises 1.2.0.1 2021-02-11 [1] CRAN (R 4.2.0) ps 1.7.1 2022-06-18 [1] CRAN (R 4.2.0) purrr 1.0.1 2023-01-10 [1] CRAN (R 4.2.0) P R6 2.5.1 2021-08-19 [?] CRAN (R 4.2.0) VP Rcpp 1.0.9 2023-01-22 [?] CRAN (R 4.2.0) (on disk 1.0.10) remotes 2.4.2 2021-11-30 [1] CRAN (R 4.2.0) renv 0.16.0 2022-09-29 [1] CRAN (R 4.2.1) P rlang 1.0.6 2022-09-24 [?] CRAN (R 4.2.0) P rstudioapi 0.14 2022-08-22 [?] CRAN (R 4.2.0) sessioninfo 1.2.2 2021-12-06 [1] CRAN (R 4.2.0) P shiny 1.7.4 2022-12-15 [?] CRAN (R 4.2.0) shinyVirga 0.19.4 2023-03-01 [1] Github (Martin-McCoy/shinyVirga@edf4dff) stringi 1.7.8 2022-07-11 [1] CRAN (R 4.2.0) P stringr 1.5.0 2022-12-02 [?] CRAN (R 4.2.0) P tibble 3.1.8 2022-07-22 [?] CRAN (R 4.2.0) urlchecker 1.0.1 2021-11-30 [1] CRAN (R 4.2.0) usethis 2.1.6 2022-05-25 [1] CRAN (R 4.2.0) P utf8 1.2.2 2021-07-24 [?] CRAN (R 4.2.0) UU 1.18.0 2023-03-01 [1] Github (yogat3ch/UU@0fd7ed7) P vctrs 0.5.2 2023-01-23 [?] CRAN (R 4.2.0) xtable 1.8-4 2019-04-21 [1] CRAN (R 4.2.0) [1] /Users/stephenholsenbeck/Library/Caches/org.R-project.R/R/renv/library/dmdu-4393acb2/R-4.2/aarch64-apple-darwin20 [2] /Users/stephenholsenbeck/Documents/R/Contributor_Repos/VirgaLabs/dmdu/renv/sandbox/R-4.2/aarch64-apple-darwin20/84ba8b13 V ── Loaded and on-disk version mismatch. P ── Loaded and on-disk path mismatch. ─────────────────────────────────────────────────────────────────────────────────────────── ```
VincentGuyader commented 1 year ago

thanks, issue is in dockerfiler:::gen_base_image .

I transfer