search

ThinkR-open / dockerfiler

Easy Dockerfile Creation from R
https://thinkr-open.github.io/dockerfiler/
Other
176 stars 27 forks source link

fix: tests that rely on renv shouldn't be performed on CRAN [urgent] #64

Closed ColinFay closed 10 months ago

ColinFay commented 11 months ago

Feedbacks after issues with revdeps for {knitr} & {withr} on CRAN :

When performing the revdep checks on CRAN for {dockerfiler}, the tests call {renv} which requires all packages used in deps to be available. By definition, they are not : for example, if the {withr} maintainers submit a new version of the package, {withr} is not available on CRAN at that exact moment, and the revdevp checks fail.

Fix : all tests that call {renv} should be skip_on_cran()

VincentGuyader commented 11 months ago

I think that as long as the version currently in master doesn't depend on renv, then it's ok...

VincentGuyader commented 10 months ago

0.2.2 is "on his way on cran"