search

ThinkR-open / dockerfiler

Easy Dockerfile Creation from R
https://thinkr-open.github.io/dockerfiler/
Other
177 stars 27 forks source link

`pak::pkg_system_requirements` deprecated #68

Closed B0ydT closed 4 months ago

B0ydT commented 9 months ago

Hi there,

I noticed this deprecation warning while building from renv. I had a play around and it looks to me pretty straightforward to upgrade it to pak::pkg_sysreqs.

I'd be very happy to submit a PR, but I just wanted to check if that would be helpful before I spend any time with it. It would require upgrading the pak requirement from >= 0.2.0 to >= 0.6.0, and I figured there might be some other catch preventing you from making the change that I've missed - I'm a pretty new user of dockerfiler.

Cheers!

VincentGuyader commented 9 months ago

HI,

Thank you for the feedback, yes, a pull request would be welcome. We might not be the quickest at accepting them, but I'll take the time to look into it promptly and thoroughly :)

B0ydT commented 8 months ago

I think I'm close to getting this working, but when testing pkg_sysreqs, I get an error for the utils and stats packages, missing a requirement. I'll dive into that as soon as possible and see if there's a fix.

Besides that, there are some formatting kinks to work out and, ironically, pkg_sysreqs calls a deprecated function itself, but I'm sure they'll change that soon enough.

B0ydT commented 8 months ago

I have what seems to be a working implementation, but when I test it, libicu-dev is missing from the dockerfile. I thought it was due to the issue I outlined above, but I ruled that out. It turns out that the original version also missed that package when I reran it. I'm guessing that a dependency may have been dropped since the last version was tested.

I've opened the PR so hopefully you can let me know if I'm missing something or if that makes sense and I should change the test.