Fix 887 and improve code coverage of `R/config.R` from 28.21% to 100%

[ilyaZar]

Fix #887

Problem: Whenever golem::document_and_reload() calls get_golem_wd() to retrieve values from a yml-config, and the user changed the location of that yml before that call, golem::document_and_reload() is not aware of that location change and fails. Specifically, guess_where_config() cannot find the location when it is not of standard type (e.g. "inst/golem-config.yml").

Fix: This PR solves this by adding a helper to guess_where_config() which finds the user config-yaml by reading its new location from user changes in "R/app_config.R".

[ALanguillaume]

Thanks a lot @ilyaZar !

I will take the time to review your PR asap. In the mean time I quickly eye-balled on the code and made a few comments.

[ilyaZar]

Done:

Just refactored the logic for the whole file because it got complicated and messy. Here is a summary of all changes of this PR so far:

• [x] 31213b092531dec280b56bc1657a302ff234ff01: add a helper named try_user_config_location() inside guess_where_config() which finds a user supplied config-yaml by reading its new path location from changes in the "R/app_config.R" file
• [x] 83a96a7cd9d9c3c1b3fb5ffb504bcd6c39c10f9e: fix a minor style issue - use && instead of & with logical scalars
• [x] 230b73da1c69ec7cfdabd586161e31df662e920b: add tests for this behavior checking that the config-yaml can be:
  1. renamed and
  2. moved to another location
• [x] 8e98808eb42a3e93330ee1778a7681ccbcb9908c: improve readability and logic of try_user_config_location(); also add support for multi-line statements of app_sys() inside R/app_config.R; update tests to check the new behaviour improving code coverage of R/config.R to 63.16%
• [x] 90ee1ca1a6db3775d1af5883f3285862f1212f3c: sub-function should output same object (fs-path type) to top level function to make comparison-checks easier; and fix a typo
• [x] a941ec17871aafe13520d01ed33ae04b8a3ecc73: rework guess_where_config() -> since the user can now set paths to his/her golem-configs this must be properly handled
• [x] a941ec17871aafe13520d01ed33ae04b8a3ecc73: add proper tests to check the previous behavior and improve code coverage for R/config.R to 68.87%
• [x] 095bfc5a4fa3b61d4b1474758f456d2238a6ea53: add more tests to cover "exotic" corner cases when trying to find the golem-config; moves code coverage of the file to 70.75%
• [x] 3917328697eb1720b9133c2c0c63736340fa20e7: remove redundant if-statement which is roughly a duplicate of the one before; worst case is that guess_where_config() fails slightly faster which is probably good as we can then handle the failure as another corner case explicitly
• [x] f3e6cb2f97d91fa22ec85b456e260c24d5ea6bb4: encapsulate yesno() into separate function call to improve function logic and make guess_where_config() testable in interactive mode via the package {mockery}
• [x] caf682a8ce8eb5c1b1072593f81e391feb88a986: based on the previous, add the mocking tests to obtain a coverage of 100% for R/config.R

• [x] 6529474d7493be58c84b8690af821de211fb6a71: document the implemented features

To-Do:

• [ ] inform the user with a print statement which config is used, or add a helper that prints the current location of the config in use?

[ilyaZar]

@VincentGuyader do you think above CI failures relate to #1072 or #1070 ? my forked branch passed the tests on my local machine hence the question.

if you point me somewhere I'll try to fix the PR myself to make it pass the CI. thanks!