ThinkR-open / golem

A Framework for Building Robust Shiny Apps
https://thinkr-open.github.io/golem/
Other
885 stars 130 forks source link

golem::use_readme_rmd(open=...) does not pass argument to usethis_use_readme_rmd(open) [BUG] #1044

Closed ilyaZar closed 1 year ago

ilyaZar commented 1 year ago

Describe the bug golem::use_readme_rmd(open=...) forgets to pass the open argument to usethis_use_readme_rmd()

So the Rmd. pops up when running 01_start.R

To Reproduce It's within an interactive session as the default sethis_use_readme_rmd(open) takes its open value from rlang::is_interactive()

Expected behavior Should be passed with open=FALSE so the .Rmd shoul not open.

ColinFay commented 1 year ago

Fixed via #1045