Fix 110 add rscignore - Githubissues

ilyaZar commented 1 year ago

Fix #110

[x] use rsconnect version 0.8.25, or skip creation of file
[x] excludes, besides what is mentioned in the issue: .here, CODE_OF_CONDUCT.md, vignettes, LICENSE.md, LICENCE.md
[x] adds entry to .Rbuildignore
[x] prints some user information along the way

[x] add basic test for add_rscignore_file()
[x] add documentation for add_rscignore_file()
[ ] refactor tests in tests-add_deploy_helpers(): add_rstudioconnect_file, add_shinyappsio_file, add_shinyserver_file have a call to add_rscignore_file() so their output is not properly tested anymore (they pass silently though)
[ ] adjust implementation to whatever happens here: https://github.com/rstudio/rsconnect/issues/774
[ ] seeing the previous issue, maybe add a func that helps with adding new entries to .rscignore (e.g. add_entry_to_rscignore())
- globbing/standard use ala .gitigore and .Rbuildignore in .rscignore not supported yet
- also man/, dev/ is not allowed atm. but man, dev is possible, see above issue (one could take care of that in a separate add_entry_to_rscignore() e.g.)

ColinFay commented 8 months ago

I'll test this in action on our Connect and let you know :)

ColinFay commented 4 months ago

ThinkR-open / golem